lkml.org 
[lkml]   [2018]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v2] staging: vboxvideo: Remove unnecessary parentheses
    Remove unneeded parentheses around the arguments of ||. This reduces
    clutter and code behave in the same way.
    Change suggested by checkpatch.pl.

    vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
    crtc->x'

    Signed-off-by: Shayenne da Luz Moura <shayenneluzmoura@gmail.com>
    ---
    Changes in v2:
    - Make the commit message more clearer.

    drivers/staging/vboxvideo/vbox_main.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/staging/vboxvideo/vbox_main.c b/drivers/staging/vboxvideo/vbox_main.c
    index 429f6a453619..10a862674789 100644
    --- a/drivers/staging/vboxvideo/vbox_main.c
    +++ b/drivers/staging/vboxvideo/vbox_main.c
    @@ -116,10 +116,10 @@ void vbox_framebuffer_dirty_rectangles(struct drm_framebuffer *fb,
    struct vbva_cmd_hdr cmd_hdr;
    unsigned int crtc_id = to_vbox_crtc(crtc)->crtc_id;

    - if ((rects[i].x1 > crtc->x + crtc->hwmode.hdisplay) ||
    - (rects[i].y1 > crtc->y + crtc->hwmode.vdisplay) ||
    - (rects[i].x2 < crtc->x) ||
    - (rects[i].y2 < crtc->y))
    + if (rects[i].x1 > crtc->x + crtc->hwmode.hdisplay ||
    + rects[i].y1 > crtc->y + crtc->hwmode.vdisplay ||
    + rects[i].x2 < crtc->x ||
    + rects[i].y2 < crtc->y)
    continue;

    cmd_hdr.x = (s16)rects[i].x1;
    --
    2.19.1
    \
     
     \ /
      Last update: 2018-10-23 19:43    [W:4.182 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site