lkml.org 
[lkml]   [2018]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 03/24] iov_iter: Add I/O discard iterator
Date
Al Viro <viro@ZenIV.linux.org.uk> wrote:

> > @@ -1060,6 +1074,9 @@ void iov_iter_revert(struct iov_iter *i, size_t unroll)
> > }
> > unroll -= i->iov_offset;
> > switch (iov_iter_type(i)) {
> > + case ITER_DISCARD:
> > + i->iov_offset = 0;
> > + return;
>
> ... the hell? That makes no sense whatsoever; what, besides this and immediately
> preceding part of iov_iter_revert() so much as looks at ->iov_offset for those?
> Just have it bugger off before the
> if (unroll <= i->iov_offset) {
> i->iov_offset -= unroll;
> return;
> }
> bit...

I didn't want to add another case before that if I could avoid it. If
iov_offset > unroll, the discard iterator really doesn't care. Maybe I should
just ignore iov_offset for the discard iterator.

David

\
 
 \ /
  Last update: 2018-10-22 18:18    [W:0.154 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site