Messages in this thread | | | Date | Mon, 22 Oct 2018 15:04:09 +0100 | From | Moritz Fischer <> | Subject | Re: [PATCH] fpga: altera_cvp: restrict registration to CvP enabled devices |
| |
Hi Andreas,
On Mon, Oct 22, 2018 at 01:15:34PM +0000, Andreas Puhm wrote:
Can you please send your patch using git-send-email?
[..]
> Subject: [PATCH] fpga: altera_cvp: restrict registration to CvP enabled devices
How about:
fpga: altera-cvp: Fix registration for CvP incapable devices
The probe function needs to verify the CvP enable bit in order to properly determine if FPGA Manager functionality can be safely enabled.
> > The altera-cvp probe function now verifies, that the PCI device supports > the CvP feature, before it registers the device. > This is done by reading the CVP_EN bit, > Bit 20 of the CVP_STATUS register (@ PCI Config Address 0x21C). > > If this bit is '1' (CvP enabled), altera-cvp will register the device > for further interaction. > If this bit is '0' (CvP disabled), altera-cvp will not register the device. >
Could you add a Fixes <hash> ("Message") tag here, I believe we had this issue since the very beginning, i.e
Fixes 34d1dc17ce97 ("fpga manager: Add Altera CvP driver")
Something like ^^^^
Thanks,
Moritz
| |