Messages in this thread | | | From | Alexander Shishkin <> | Subject | Re: [RFC][PATCH] perf: Rewrite core context handling | Date | Mon, 22 Oct 2018 16:26:22 +0300 |
| |
Peter Zijlstra <peterz@infradead.org> writes:
> @@ -1926,8 +1920,9 @@ static void perf_group_detach(struct per > add_event_to_groups(sibling, event->ctx); > > if (sibling->state == PERF_EVENT_STATE_ACTIVE) { > + struct perf_event_pmu_context *pmu_ctx = event->pmu_ctx; > struct list_head *list = sibling->attr.pinned ? > - &ctx->pinned_active : &ctx->flexible_active; > + &pmu_ctx->pinned_active : &pmu_ctx->flexible_active; > > list_add_tail(&sibling->active_list, list);
Ok, since I'm getting to the bottom of things: the event::active_list is actually event::active_entry, which also does exist, but is not used anywhere other than its initialization. Let's maybe get rid of the _list?
Regards, -- Alex
| |