lkml.org 
[lkml]   [2018]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)
    On Mon, Oct 22, 2018 at 2:41 AM, Miguel Ojeda
    <miguel.ojeda.sandonis@gmail.com> wrote:
    > On Mon, Oct 22, 2018 at 11:36 AM Kees Cook <keescook@chromium.org> wrote:
    >>
    >> We need to make sure the static analyzers are happy with either
    >> method. Additionally, when was -Wimplicit-fallthrough added to GCC? If
    >> it was added _before_ the attribute, we need to continue using the
    >> comment style otherwise we lose coverage even with gcc itself.
    >> Additionally, does Clang support this attribute (it supports
    >> -Wimplicit-fallthrough).
    >
    > Please take a look at the rationale (also more details at the linked thread):
    >
    > * gcc 7.1 added -Wimplicit-fallthrough at the same time as the
    > attribute and the comment parsing.

    Ah, perfect. I missed this. :)

    > * clang does *not* support the attribute in C.

    Well that's not good. :)

    -Kees

    --
    Kees Cook
    Pixel Security

    \
     
     \ /
      Last update: 2018-10-22 12:53    [W:3.970 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site