Messages in this thread | | | From | Wolfram Sang <> | Subject | [PATCH 0/3] spi: simplify getting .driver_data | Date | Sun, 21 Oct 2018 22:00:44 +0200 |
| |
I got tired of fixing this in Renesas drivers manually, so I took the big hammer. Remove this cumbersome code pattern which got copy-pasted too much already:
- struct platform_device *pdev = to_platform_device(dev); - struct ep93xx_keypad *keypad = platform_get_drvdata(pdev); + struct ep93xx_keypad *keypad = dev_get_drvdata(dev);
A branch, tested by buildbot, can be found here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git coccinelle/get_drvdata
I have been asked if it couldn't be done for dev_set_drvdata as well. I checked it and did not find one occasion where it could be simplified like this. Not much of a surprise because driver_data is usually set in probe() functions which access struct platform_device in many other ways.
I am open for other comments, suggestions, too, of course.
Here is the cocci-script I created:
@@ struct device* d; identifier pdev; expression *ptr; @@ ( - struct platform_device *pdev = to_platform_device(d); | - struct platform_device *pdev; ... - pdev = to_platform_device(d); ) <... when != pdev - &pdev->dev + d ...>
ptr = - platform_get_drvdata(pdev) + dev_get_drvdata(d)
<... when != pdev - &pdev->dev + d ...>
Kind regards,
Wolfram
Wolfram Sang (3): spi: spi-rspi: simplify getting .driver_data spi: spi-sh-msiof: simplify getting .driver_data spi: spi-zynqmp-gqspi: simplify getting .driver_data
drivers/spi/spi-rspi.c | 6 ++---- drivers/spi/spi-sh-msiof.c | 6 ++---- drivers/spi/spi-zynqmp-gqspi.c | 6 ++---- 3 files changed, 6 insertions(+), 12 deletions(-)
-- 2.19.0
| |