Messages in this thread | | | Date | Mon, 22 Oct 2018 11:14:57 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH] skd: fix unchecked return values |
| |
On Fri, Oct 19, 2018 at 08:44:17PM +0200, Gustavo A. R. Silva wrote: > Check return values of dma_set_mask_and_coherent(). > > Otherwise, if dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); > fails, the following piece of code will be executed even when the call > to dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); returns 0: > > dev_err(&pdev->dev, "DMA mask error %d\n", rc); > goto err_out_regions; > > Addresses-Coverity-ID: 1474553 ("Unchecked return value") > Fixes: 138126214868 ("skd: switch to the generic DMA API") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Thanks, looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |