lkml.org 
[lkml]   [2018]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 077/137] nfsd: fix corrupted reply to badly ordered compound
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "J. Bruce Fields" <bfields@redhat.com>

    [ Upstream commit 5b7b15aee641904ae269be9846610a3950cbd64c ]

    We're encoding a single op in the reply but leaving the number of ops
    zero, so the reply makes no sense.

    Somewhat academic as this isn't a case any real client will hit, though
    in theory perhaps that could change in a future protocol extension.

    Reviewed-by: Jeff Layton <jlayton@kernel.org>
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/nfsd/nfs4proc.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/fs/nfsd/nfs4proc.c
    +++ b/fs/nfsd/nfs4proc.c
    @@ -1725,6 +1725,7 @@ nfsd4_proc_compound(struct svc_rqst *rqs
    if (status) {
    op = &args->ops[0];
    op->status = status;
    + resp->opcnt = 1;
    goto encode_op;
    }


    \
     
     \ /
      Last update: 2018-10-02 15:51    [W:4.023 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site