lkml.org 
[lkml]   [2018]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 100/137] USB: usbdevfs: restore warning for nonsensical flags
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Oliver Neukum <oneukum@suse.com>

    commit 81e0403b26d94360abd1f6a57311337973bc82cd upstream.

    If we filter flags before they reach the core we need to generate our
    own warnings.

    Signed-off-by: Oliver Neukum <oneukum@suse.com>
    Fixes: 0cb54a3e47cb ("USB: debugging code shouldn't alter control flow")
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/core/devio.c | 5 +++++
    1 file changed, 5 insertions(+)

    --- a/drivers/usb/core/devio.c
    +++ b/drivers/usb/core/devio.c
    @@ -1715,6 +1715,11 @@ static int proc_do_submiturb(struct usb_
    u |= URB_NO_INTERRUPT;
    as->urb->transfer_flags = u;

    + if (!allow_short && uurb->flags & USBDEVFS_URB_SHORT_NOT_OK)
    + dev_warn(&ps->dev->dev, "Requested nonsensical USBDEVFS_URB_SHORT_NOT_OK.\n");
    + if (!allow_zero && uurb->flags & USBDEVFS_URB_ZERO_PACKET)
    + dev_warn(&ps->dev->dev, "Requested nonsensical USBDEVFS_URB_ZERO_PACKET.\n");
    +
    as->urb->transfer_buffer_length = uurb->buffer_length;
    as->urb->setup_packet = (unsigned char *)dr;
    dr = NULL;

    \
     
     \ /
      Last update: 2018-10-02 15:46    [W:4.090 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site