lkml.org 
[lkml]   [2018]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] usbnet: smsc95xx: add kconfig for turbo mode
On Tue, Oct 02, 2018 at 10:26:42AM +0100, Ben Dooks wrote:
> Add a configuration option for the default state of turbo mode
> on the smsc95xx networking driver. Some systems it is better
> to default this to off as it causes significant increases in
> soft-irq load.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> drivers/net/usb/Kconfig | 9 +++++++++
> drivers/net/usb/smsc95xx.c | 2 +-
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> index 418b0904cecb..a32f1a446ce9 100644
> --- a/drivers/net/usb/Kconfig
> +++ b/drivers/net/usb/Kconfig
> @@ -351,6 +351,15 @@ config USB_NET_SMSC95XX
> This option adds support for SMSC LAN95XX based USB 2.0
> 10/100 Ethernet adapters.
>
> +config USB_NET_SMSC95XX_TURBO
> + bool "Use turbo receive mode by default"
> + depends on USB_NET_SMSC95XX
> + default y
> + help
> + This options sets the default turbo mode settings for the
> + driver's receive path. These can also be altered by the
> + turbo_mode module parameter.
> +

Hi Ben

Is it worth adding a comment here why you would want to turn it off?
To reduce soft-irq load?

Thanks
Andrew

\
 
 \ /
  Last update: 2018-10-02 14:47    [W:1.772 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site