Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 2 Oct 2018 10:49:53 +0200 | Subject | Re: [PATCH] pinctrl: msm: Actually use function 0 for gpio selection |
| |
On Mon, Oct 1, 2018 at 11:49 PM Stephen Boyd <swboyd@chromium.org> wrote:
> This code needs to select function #0, which is the first int in the > array of functions, not the number 0 which may or may not be the > function for "GPIO mode" per the enum mapping. We were getting lucky on > SDM845, where this was tested, because the function 0 matched the enum > value for "GPIO mode". On other platforms, e.g. MSM8996, the gpio enum > value is the last one in the list so this code doesn't work and we see a > warning at boot. Fix it by grabbing the first element out of the array > of functions. > > Cc: Doug Anderson <dianders@chromium.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Niklas Cassel <niklas.cassel@linaro.org> > Reported-by: Niklas Cassel <niklas.cassel@linaro.org> > Fixes: 1de7ddb3a15c ("pinctrl: msm: Mux out gpio function with gpio_request()") > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Patch applied with all the tags.
Yours, Linus Walleij
| |