lkml.org 
[lkml]   [2018]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v5 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation
Hi,
On Mon, Oct 1, 2018 at 6:32 PM Ryan Case <ryandcase@chromium.org> wrote:
>
> From: Girish Mahadevan <girishm@codeaurora.org>
>
> Bindings for Qualcomm Quad SPI used on SoCs such as sdm845.
>
> Signed-off-by: Girish Mahadevan <girishm@codeaurora.org>
> Signed-off-by: Ryan Case <ryandcase@chromium.org>
> ---
>
> Changes in v5:
> - None
>
> Changes in v4:
> - Changed qspi@ to spi@ and device@ to flash@ to match Rob's review

Rob said that with those changes you could add his reviewed by [1], so
this patch should have carried:

Reviewed-by: Rob Herring <robh@kernel.org>

I'd also say that usually when changes are minor you can make a
judgement call and carry previous reviews. If there's any question
about whether previous reviews can be carried you can mention it
somewhere in your changelog. In this particular case I would have
called the changes minor / non-controversial so I would have kept
Stephen and my reviews when posting the new patch. In any case
Stephen has already re-provided his review and you can feel free to
add:

Reviewed-by: Douglas Anderson <dianders@chromium.org>


[1] https://lkml.kernel.org/r/20180927204624.GA7072@bogus

\
 
 \ /
  Last update: 2018-10-02 17:15    [W:0.087 / U:4.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site