lkml.org 
[lkml]   [2018]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 04/18] powerpc/pseries: add of_node_put() in dlpar_detach_node()
    Date
    From: Frank Rowand <frank.rowand@sony.com>

    "of: overlay: add missing of_node_get() in __of_attach_node_sysfs"
    added a missing of_node_get() to __of_attach_node_sysfs(). This
    results in a refcount imbalance for nodes attached with
    dlpar_attach_node(). The calling sequence from dlpar_attach_node()
    to __of_attach_node_sysfs() is:

    dlpar_attach_node()
    of_attach_node()
    __of_attach_node_sysfs()

    Signed-off-by: Frank Rowand <frank.rowand@sony.com>
    ---

    ***** UNTESTED. I need people with the affected PowerPC systems
    ***** (systems that dynamically allocate and deallocate
    ***** devicetree nodes) to test this patch.

    arch/powerpc/platforms/pseries/dlpar.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c
    index a0b20c03f078..e3010b14aea5 100644
    --- a/arch/powerpc/platforms/pseries/dlpar.c
    +++ b/arch/powerpc/platforms/pseries/dlpar.c
    @@ -272,6 +272,8 @@ int dlpar_detach_node(struct device_node *dn)
    if (rc)
    return rc;

    + of_node_put(dn);
    +
    return 0;
    }

    --
    Frank Rowand <frank.rowand@sony.com>
    \
     
     \ /
      Last update: 2018-10-19 00:49    [W:5.750 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site