lkml.org 
[lkml]   [2018]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/4] ath10k: snoc: fix unabalanced regulator error handling
Hi,

On Fri, Oct 12, 2018 at 5:55 PM Brian Norris <briannorris@chromium.org> wrote:
> + if (vreg_info->settle_delay)
> + udelay(vreg_info->settle_delay);

Not new to your patch, but this seems like a duplication of what the
regulator framework is doing for you. There are plenty of regulator
properties describing lots of different types delays and that would be
the place to put it. Doing so makes it automatically easy for boards
to specify a different delay if they have different ramp
characteristics (like someone put a bigger capacitor on the line or
somesuch).

At the moment it would be easy for someone to submit a patch to kill
the settle delay in this driver this since the entire vreg_cfg table
has 0 for the settle delay.


> +static int __ath10k_snoc_vreg_off(struct ath10k *ar,
> + struct ath10k_vreg_info *vreg_info)
> +{
> + int ret;
> +
> + ath10k_dbg(ar, ATH10K_DBG_SNOC, "snoc regulator %s being disabled\n",
> + vreg_info->name);
> +
> + ret = regulator_disable(vreg_info->reg);
> + if (ret)
> + ath10k_err(ar, "failed to disable regulator %s\n",
> + vreg_info->name);
> +
> + ret = regulator_set_load(vreg_info->reg, 0);
> + if (ret < 0)
> + ath10k_err(ar, "failed to set load %s\n", vreg_info->name);
> +
> + ret = regulator_set_voltage(vreg_info->reg, 0, vreg_info->max_v);
> + if (ret)
> + ath10k_err(ar, "failed to set voltage %s\n", vreg_info->name);

Not new to your patch, but ick, forcing someone to manually set the
load / voltage of a regulator that they've turned off is silly. It's
only list to try to send a patch to remedy this situation. Let me try
to put that higher on my plate.


...just like with the clock patch I suspect that some of this is
duplicating the "regulator_bulk" APIs. ...though I guess maybe we
can't use those too easily until we can avoid setting voltage and
current so much... In any case, your patch overall looks good and an
improvement.


Reviewed-by: Douglas Anderson <dianders@chromium.org>

\
 
 \ /
  Last update: 2018-10-18 19:55    [W:0.164 / U:2.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site