lkml.org 
[lkml]   [2018]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:x86/urgent] x86/fpu: Remove second definition of fpu in __fpu__restore_sig()
    Commit-ID:  6aa676761d4c1acfa31320e55fa1f83f3fcbbc7a
    Gitweb: https://git.kernel.org/tip/6aa676761d4c1acfa31320e55fa1f83f3fcbbc7a
    Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    AuthorDate: Tue, 16 Oct 2018 22:25:24 +0200
    Committer: Ingo Molnar <mingo@kernel.org>
    CommitDate: Wed, 17 Oct 2018 12:30:31 +0200

    x86/fpu: Remove second definition of fpu in __fpu__restore_sig()

    Commit:

    c5bedc6847c3b ("x86/fpu: Get rid of PF_USED_MATH usage, convert it to fpu->fpstate_active")

    introduced the 'fpu' variable at top of __restore_xstate_sig(),
    which now shadows the other definition:

    arch/x86/kernel/fpu/signal.c:318:28: warning: symbol 'fpu' shadows an earlier one
    arch/x86/kernel/fpu/signal.c:271:20: originally declared here

    Remove the shadowed definition of 'fpu', as the two definitions are the same.

    Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    Reviewed-by: Andy Lutomirski <luto@kernel.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Dave Hansen <dave.hansen@linux.intel.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Fixes: c5bedc6847c3b ("x86/fpu: Get rid of PF_USED_MATH usage, convert it to fpu->fpstate_active")
    Link: http://lkml.kernel.org/r/20181016202525.29437-3-bigeasy@linutronix.de
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    ---
    arch/x86/kernel/fpu/signal.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/arch/x86/kernel/fpu/signal.c b/arch/x86/kernel/fpu/signal.c
    index 23f1691670b6..61a949d84dfa 100644
    --- a/arch/x86/kernel/fpu/signal.c
    +++ b/arch/x86/kernel/fpu/signal.c
    @@ -314,7 +314,6 @@ static int __fpu__restore_sig(void __user *buf, void __user *buf_fx, int size)
    * thread's fpu state, reconstruct fxstate from the fsave
    * header. Validate and sanitize the copied state.
    */
    - struct fpu *fpu = &tsk->thread.fpu;
    struct user_i387_ia32_struct env;
    int err = 0;

    \
     
     \ /
      Last update: 2018-10-18 08:23    [W:2.996 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site