lkml.org 
[lkml]   [2018]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V9 05/21] csky: System Call
On Wed, Oct 17, 2018 at 05:02:33PM +0200, Arnd Bergmann wrote:
> On Tue, Oct 16, 2018 at 5:01 AM Guo Ren <ren_guo@c-sky.com> wrote:
> >
> > This patch adds files related to syscall.
> >
> > Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> > Cc: Arnd Bergmann <arnd@arndb.de>
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>
> I had a detailed look at this one and provided lots of comments, however
> one tiny thing escaped me:
>
> > +#define __NR_set_thread_area (__NR_arch_specific_syscall + 0)
> > +__SYSCALL(__NR_set_thread_area, sys_set_thread_area)
> > +#define __NR_cacheflush (__NR_arch_specific_syscall + 4)
> > +__SYSCALL(__NR_cacheflush, sys_cacheflush)
>
> It's odd that the second one uses __NR_arch_specific_syscall + 4 rather
> than +1. If you can still change that changing too much other stuff,
> that might avoid some head-scratching later. If it causes problems,
> just leave it and maybe add a comment saying that the numbers
> inbetween are still available.
Change to (__NR_arch_specific_syscall + 1) is ok for now.

Best Regards
Guo Ren

\
 
 \ /
  Last update: 2018-10-18 04:03    [W:0.060 / U:13.444 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site