lkml.org 
[lkml]   [2018]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] x86/mm/pat: Disable preemption around __flush_tlb_all()
On Wed, Oct 17, 2018 at 06:00:51PM +0200, 'Sebastian Andrzej Siewior' wrote:
> On 2018-10-17 17:47:07 [+0200], Peter Zijlstra wrote:
> > > > Ideally we'd never ever merge anything that only does local invalidates,
> > > > on a global address space, that's just broken.
> > >
> > > A little bit late to lament about that.
> >
> > For this, yes :/ But for future stuff we should really not allow such
> > things anymore.
>
> so we stay as is?

Well, we can do that preempt kludge you propose to shut up the warning I
suppose.

But a kludge it is. That code really wants a global invalidate, but we
cannot (not without massive surgery in any case).

\
 
 \ /
  Last update: 2018-10-17 18:25    [W:0.063 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site