lkml.org 
[lkml]   [2018]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V9 14/21] csky: User access
On Tue, Oct 16, 2018 at 5:05 AM Guo Ren <ren_guo@c-sky.com> wrote:
>
> The patch adds "user access from kernel" codes.
>
> Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/csky/include/asm/uaccess.h | 416 ++++++++++++++++++++++++++++++++++++++++
> arch/csky/lib/usercopy.c | 262 +++++++++++++++++++++++++
> 2 files changed, 678 insertions(+)
> create mode 100644 arch/csky/include/asm/uaccess.h
> create mode 100644 arch/csky/lib/usercopy.c

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

The 64-bit __put_user() is usually what everyone gets wrong, but
your version seems fine. Also the access_ok() checks and
the copy_to_user() result value all look correct.

Arnd

\
 
 \ /
  Last update: 2018-10-17 17:38    [W:0.162 / U:14.276 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site