lkml.org 
[lkml]   [2018]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4 08/13] arch/x86: Bring few more functions into the resource structure
Date
Hi Fenghua,

On 10/16/2018 06:45 PM, Fenghua Yu wrote:
> On Mon, Oct 15, 2018 at 08:55:49PM +0000, Moger, Babu wrote:
>> update_mba_bw : Feedback loop bandwidth update functionality is not
>> needed for AMD.
>
> Will you implement update_mba_bw() for AMD in future?

No. There is no plan.

>
>> list_for_each_entry(crgrp, head, mon.crdtgrp_list)
>> mbm_update(d, crgrp->mon.rmid);
>>
>> - if (is_mba_sc(NULL))
>> - update_mba_bw(prgrp, d);
>> + if (is_mba_sc(NULL)) {
>> + r_mba = &rdt_resources_all[RDT_RESOURCE_MBA];
>> + if (r_mba->update_mba_bw)
>> + r_mba->update_mba_bw(prgrp, d);
>> + }
>
> Mount option "mba_MBps" is not implemented on AMD. Then don't
> call set_mba_sc(true) in parse_rdtgroupfs_options().
>
> Thus, you don't need to change this code here because is_mba_sc(NULL) is
> false on AMD.

Yes. is_mba_sc(NULL) is false on AMD. I can remove this change.

>
> Thanks.
>
> -Fenghua
>
\
 
 \ /
  Last update: 2018-10-17 16:51    [W:0.055 / U:7.552 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site