Messages in this thread | | | From | Fabio Estevam <> | Date | Wed, 17 Oct 2018 09:48:21 -0300 | Subject | Re: [PATCH v4 2/4] crypto: mxs-dcp - Add support for dcp clk |
| |
Hi Leonard,
On Wed, Oct 17, 2018 at 9:38 AM Leonard Crestez <leonard.crestez@nxp.com> wrote: > > On 6ull and 6sll the DCP block has a clock which needs to be explicitly > enabled. > > Add minimal handling for this at probe/remove time. > > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> > ---
Please always explain what changed from the previous patch version.
> + /* Restart the DCP block. */ > + ret = stmp_reset_block(sdcp->base); > + if (ret) { > + dev_err(dev, "Failed reset\n"); > + goto err_disable_unprepare_clk; > + }
This seems like an unrelated change that should be in a separate patch.
Also, this was not present in v3, so it is better to explain that this has been introduced in v4.
| |