lkml.org 
[lkml]   [2018]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 00/30] softirq: Make softirqs soft-interruptible (+ per vector disablement)
On Thu, 11 Oct 2018 01:11:47 +0200
Frederic Weisbecker <frederic@kernel.org> wrote:

> 945 files changed, 13857 insertions(+), 9767 deletions(-)

Impressive :)

I have to ask a dumb question, though. Might it not be better to add a
new set of functions like:

local_softirq_disable(mask);
spin_lock_softirq(lock, mask);

Then just define the existing functions to call the new ones with
SOFTIRQ_ALL_MASK? It would achieve something like the same result with
far less churn and conflict potential; then individual call sites could be
changed at leisure? For extra credit, somebody could do a checkpatch rule
to keep new calls to the _bh functions from being added.

Thanks,

jon

\
 
 \ /
  Last update: 2018-10-17 00:04    [W:0.163 / U:5.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site