Messages in this thread | | | From | Stephen Boyd <> | Subject | Re: [PATCH v2] clk: s2mps11: Fix matching when built as module and DT node contains compatible | Date | Tue, 16 Oct 2018 14:45:32 -0700 |
| |
Quoting Krzysztof Kozlowski (2018-08-29 12:20:10) > When driver is built as module and DT node contains clocks compatible > (e.g. "samsung,s2mps11-clk"), the module will not be autoloaded because > module aliases won't match. > > The modalias from uevent: of:NclocksT<NULL>Csamsung,s2mps11-clk > The modalias from driver: platform:s2mps11-clk > > The devices are instantiated by parent's MFD. However both Device Tree > bindings and parent define the compatible for clocks devices. In case > of module matching this DT compatible will be used. > > The issue will not happen if this is a built-in (no need for module > matching) or when clocks DT node does not contain compatible (not > correct from bindings perspective but working for driver). > > Note when backporting to stable kernels: adjust the list of device ID > entries. > > Cc: <stable@vger.kernel.org> > Fixes: 53c31b3437a6 ("mfd: sec-core: Add of_compatible strings for clock MFD cells") > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > Acked-by: Stephen Boyd <sboyd@kernel.org> > > ---
Applied to clk-next
| |