Messages in this thread | | | Subject | Re: [PATCH] scsi: ips: fix missing break in switch | From | "Martin K. Petersen" <> | Date | Tue, 16 Oct 2018 21:19:20 -0400 |
| |
Finn,
> This looks wrong to me. I think you've just prevented all START STOP > commands sent to logical volumes from reaching > > return ((*ha->func.issue) (ha, scb)); > > I think a better patch is to add a "fall though" comment not a "break" > statement. (I no longer have access to a ServeRAID board so I can't > test.)
When I looked at this a few days ago, it seemed that the fallthrough to the TUR/INQUIRY case statement was accidental and that the intent was to quickly complete START_STOP unit (which probably doesn't make much sense for a RAID device anyway).
See the case statements above for another fast exit scenario.
Sadly I have no way to test this. It just stuck out like a false positive in Gustavo's fallthrough markup patch.
-- Martin K. Petersen Oracle Linux Engineering
| |