lkml.org 
[lkml]   [2018]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 9/9] ASoC: tegra_sgtl5000: fix platform name vs. of_node assignement
From
Date

On 17/10/2018 20:16, Mark Brown wrote:
> On Wed, Oct 17, 2018 at 02:28:22PM +0000, Marcel Ziswiler wrote:
>
>> Some questions:
>
>> - How exactly are devm allocations supposed to work concerning probe
>> deferrals?
>
> Probe deferrals are just normal probe errors, any devm_ allocated stuff
> gets unwound.
>
>> - Does or should the platform get cleared during a probe deferral
>> cycle?
>
>> - If so, why does that not work?
>
> Is something writing to static data when it should be writing to
> dynamically allocated data? That's what this sounds like, we shouldn't
> be modifying any static data and any data dynamically allocated during
> probe ought to be being discarded.

Marcel, it maybe worth looking at what happens in the 2nd call to
snd_soc_init_platform() following the probe deferral. Also pay attention
to the value of 'dai_link->platform_name' in snd_soc_init_platform() on
both 1st and 2nd call. Seems that on the 2nd time the function is called
the value is not NULL???

Cheers
Jon

--
nvpublic

\
 
 \ /
  Last update: 2018-10-17 21:51    [W:0.245 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site