lkml.org 
[lkml]   [2018]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] mm, page_alloc: set num_movable in move_freepages()
From
Date
On 10/5/18 11:21 PM, Andrew Morton wrote:
> On Fri, 5 Oct 2018 13:56:39 -0700 (PDT) David Rientjes <rientjes@google.com> wrote:
>
>> If move_freepages() returns 0 because zone_spans_pfn(), *num_movable can
>
> move_free_pages_block()? !zone_spans_pfn()?

Also the subject would be more accurate if it said "initialize
num_movable in move_freepages_block()" ?

Otherwise,
Acked-by: Vlastimil Babka <vbabka@suse.cz>

>> hold the value from the stack because it does not get initialized in
>> move_freepages().
>>
>> Move the initialization to move_freepages_block() to guarantee the value
>> actually makes sense.
>>
>> This currently doesn't affect its only caller where num_movable != NULL,
>> so no bug fix, but just more robust.
>>
>> ...
>

\
 
 \ /
  Last update: 2018-10-16 14:24    [W:0.015 / U:32.172 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site