[lkml]   [2018]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] usb: gadget: storage: Fix Spectre v1 vulnerability

Hi Greg,

"Gustavo A. R. Silva" <> writes:

> num can be indirectly controlled by user-space, hence leading to
> a potential exploitation of the Spectre variant 1 vulnerability.
> This issue was detected with the help of Smatch:
> drivers/usb/gadget/function/f_mass_storage.c:3177 fsg_lun_make() warn:
> potential spectre issue 'fsg_opts->common->luns' [r] (local cap)
> Fix this by sanitizing num before using it to index
> fsg_opts->common->luns
> Notice that given that speculation windows are large, the policy is
> to kill the speculation on the first load and not worry if it can be
> completed with a dependent load/store [1].
> [1]
> Cc:
> Signed-off-by: Gustavo A. R. Silva <>

Can you still take this as an urgent fix?

Acked-by: Felipe Balbi <>


 \ /
  Last update: 2018-10-16 13:28    [W:0.041 / U:2.992 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site