lkml.org 
[lkml]   [2018]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf tools: Store ids for events with their own cpus perf_event__synthesize_event_update_cpus
On Tue, Oct 16, 2018 at 10:10:20AM +0100, John Garry wrote:
> On 15/10/2018 20:15, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Oct 12, 2018 at 02:25:49PM +0100, John Garry escreveu:
> > > On 09/10/2018 11:00, Jiri Olsa wrote:
> > > > On Thu, Oct 04, 2018 at 10:20:39AM +0100, John Garry wrote:
> > > >
> > > > SNIP
> > > >
> > > > > > We synthesize an update event that needs to touch the evsel
> > > > > > id array, which is not defined at that time. Fixing this by
> > > > > > forcing the id allocation for events with theeir own cpus.
> > >
> > > /s/theeir/their/
> > >
> > > > > >
> > > > > > Reported-by: John Garry <john.garry@huawei.com>
> > > > > > Link: http://lkml.kernel.org/n/tip-8x4n7o34yheigoxm1jibflm6@git.kernel.org
> > > > >
> > > > > Tested-by: John Garry <john.garry@huawei.com>
> > > > >
> > > > > In terms of adding to stable, LT v4.14 is not affected, but 4.18.x is.
> > > > >
> > > > > Thanks,
> > > > > John
> > > >
> > > > Arnaldo, could you please pick up this one
> > > >
> > >
> > > Just a friendly reminder on this patch.
> > >
> > > How about re-send with an updated commit message also?
> >
> > I'll fix up the commit message and apply, thanks.
> >
>
> Much appreciated.
>
> BTW, I think that we should add a fixes tag. But I'm not sure if this patch
> fixes the commit I bisected to earlier (bfd8f72c2778f5bd63d), or that same
> commit just exposed some latent bug.
>
> Jirka, Andi, Do you know?

yes, that commit moved it to record, which resulted in this fault

Arnaldo, could you please add:
Fixes: bfd8f72c2778 ("perf record: Synthesize unit/scale/... in event update")

thanks,
jirka

\
 
 \ /
  Last update: 2018-10-16 12:48    [W:0.039 / U:7.276 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site