lkml.org 
[lkml]   [2018]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch
From
Date
Ho Laurent,

On 16/10/18 01:11, Laurent Pinchart wrote:
> Hi Enric,
>
> Thank you for the patch.
>
> On Saturday, 13 October 2018 14:18:44 EEST Enric Balletbo i Serra wrote:
>> This patch avoids that building the bridge/analogix source code with
>> smatch triggers complaints about inconsistent indenting.
>>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> ---
>>
>> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
>> b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index
>> d68986cea132..75e2649d7515 100644
>> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
>> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
>> @@ -1219,12 +1219,12 @@ static int analogix_dp_bridge_attach(struct
>> drm_bridge *bridge) * plat_data->attch return, that's why we record the
>> connector
>> * point after plat attached.
>> */
>> - if (dp->plat_data->attach) {
>> - ret = dp->plat_data->attach(dp->plat_data, bridge, connector);
>> - if (ret) {
>> - DRM_ERROR("Failed at platform attch func\n");
>> - return ret;
>> - }
>> + if (dp->plat_data->attach) {
>> + ret = dp->plat_data->attach(dp->plat_data, bridge, connector);
>> + if (ret) {
>> + DRM_ERROR("Failed at platform attch func\n");
>> + return ret;
>> + }
>> }
>
> This looks good to me. While at it, could you s/attch/attach/ ? With that
> fixed,

Sure, will do now, just preparing v2.

>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
>> if (dp->plat_data->panel) {
>

\
 
 \ /
  Last update: 2018-10-16 11:44    [W:0.037 / U:12.196 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site