Messages in this thread | | | Date | Tue, 16 Oct 2018 16:39:07 +1100 (AEDT) | From | Finn Thain <> | Subject | Re: [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines |
| |
On Mon, 15 Oct 2018, Hannes Reinecke wrote:
> > However, the function declaration really is a worry, as the actual function > body only exists when the config option is enabled. > So either add a dummy function or surround the function declaration by > CONFIG_ESP_PIO. > Otherwise I think Dan Carpenter and the likes are guaranteed to send you a > nice mail complaining about this ... >
Perhaps I've misunderstood your concern here. Is it a problem that esp_scsi.ko may or may not export the function, depending on .config?
For example, if esp_scsi.ko came from a build with CONFIG_SUN3X_ESP=y && !CONFIG_SCSI_ZORRO_ESP && !CONFIG_SCSI_MAC_ESP, then it would export no esp_send_pio_cmd() symbol.
A dummy function (mentioned above) might then avoid a link error from "modprobe zorro_esp" or "modprobe mac_esp" in this scenario. (The modules would load but fail to work properly.)
This seems a bit too contrived so I'll post v3 for you to consider.
--
| |