lkml.org 
[lkml]   [2018]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] spi: Make GPIO CSs honour the SPI_NO_CS flag
    Date
    On Tue, 2018-10-16 at 10:03 +0100, Mark Brown wrote:
    > On Mon, Oct 15, 2018 at 06:34:18PM +0000, Trent Piepho wrote:
    >
    > > What about the calls to spi->controller->set_cs() after this? Should a
    > > driver provided set_cs method be responsible for checking SPI_NO_CS?
    > > Or should it not be called in the first place?
    >
    > This seems like something that should be done entirely in the framework,
    > no point in every single driver having to open code the same thing.
    >
    > > I imagine it depends on what set_cs needs to do, which might not be
    > > solely related to changing the CS line.
    >
    > It should be. If something is hanging other work on set_cs() then it's
    > going to break.

    IIRC, for spi-dw setting CS is the only way to trigger the master to do
    anything. I think orion is the same way. Even if you don't want a CS
    line the driver still needs to assert one. Which CS to use as the
    dummy CS is a challenge that has come up before.

    bcm2835_spi_set_cs() does check SPI_NO_CS, but it still does a lot of
    other stuff even if that is set, likely because of the above issue.
    \
     
     \ /
      Last update: 2018-10-16 21:30    [W:3.358 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site