Messages in this thread | | | Subject | Re: [PATCH] staging: add nrf24 driver | From | Joe Perches <> | Date | Mon, 15 Oct 2018 17:06:04 -0700 |
| |
On Tue, 2018-10-16 at 01:17 +0200, Marcin Ciupak wrote: > This patch adds driver for Nordic Semiconductor nRF24L01+ radio module.
[] > diff --git a/drivers/staging/nrf24/nrf24_hal.c b/drivers/staging/nrf24/nrf24_hal.c
[] > +static ssize_t nrf24_read_reg(struct spi_device *spi, u8 addr) > +{ > + ssize_t ret; > + > + ret = spi_w8r8(spi, addr); > + > + if (ret < 0) > + dev_dbg(&spi->dev, "%s: read 0x%X FAILED", __func__, addr);
Please add terminating newlines to all logging formats
dev_dbg(&spi->dev, "%s: read 0x%X FAILED\n", __func__, addr);
etc...
| |