lkml.org 
[lkml]   [2018]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 024/109] tipc: fix flow control accounting for implicit connect
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>

    [ Upstream commit 92ef12b32feab8f277b69e9fb89ede2796777f4d ]

    In the case of implicit connect message with data > 1K, the flow
    control accounting is incorrect. At this state, the socket does not
    know the peer nodes capability and falls back to legacy flow control
    by return 1, however the receiver of this message will perform the
    new block accounting. This leads to a slack and eventually traffic
    disturbance.

    In this commit, we perform tipc_node_get_capabilities() at implicit
    connect and perform accounting based on the peer's capability.

    Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>
    Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/tipc/socket.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/net/tipc/socket.c
    +++ b/net/tipc/socket.c
    @@ -1063,8 +1063,10 @@ static int __tipc_sendstream(struct sock
    /* Handle implicit connection setup */
    if (unlikely(dest)) {
    rc = __tipc_sendmsg(sock, m, dlen);
    - if (dlen && (dlen == rc))
    + if (dlen && dlen == rc) {
    + tsk->peer_caps = tipc_node_get_capabilities(net, dnode);
    tsk->snt_unacked = tsk_inc(tsk, dlen + msg_hdr_sz(hdr));
    + }
    return rc;
    }


    \
     
     \ /
      Last update: 2018-10-16 19:38    [W:2.386 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site