lkml.org 
[lkml]   [2018]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] selftests: kvm: Fix -Wformat warnings
From
Date
On 10/16/2018 08:13 AM, Andrea Parri wrote:
> Fixes the following warnings:
>
> dirty_log_test.c: In function ‘help’:
> dirty_log_test.c:216:9: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘int’ [-Wformat=]
> printf(" -i: specify iteration counts (default: %"PRIu64")\n",
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from include/test_util.h:18:0,
> from dirty_log_test.c:16:
> /usr/include/inttypes.h:105:34: note: format string is defined here
> # define PRIu64 __PRI64_PREFIX "u"
> dirty_log_test.c:218:9: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘int’ [-Wformat=]
> printf(" -I: specify interval in ms (default: %"PRIu64" ms)\n",
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from include/test_util.h:18:0,
> from dirty_log_test.c:16:
> /usr/include/inttypes.h:105:34: note: format string is defined here
> # define PRIu64 __PRI64_PREFIX "u"
>
> Signed-off-by: Andrea Parri <andrea.parri@amarulasolutions.com>
> ---
> tools/testing/selftests/kvm/dirty_log_test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/dirty_log_test.c b/tools/testing/selftests/kvm/dirty_log_test.c
> index 0c2cdc105f968..a9c4b5e21d7e7 100644
> --- a/tools/testing/selftests/kvm/dirty_log_test.c
> +++ b/tools/testing/selftests/kvm/dirty_log_test.c
> @@ -31,9 +31,9 @@
> /* How many pages to dirty for each guest loop */
> #define TEST_PAGES_PER_LOOP 1024
> /* How many host loops to run (one KVM_GET_DIRTY_LOG for each loop) */
> -#define TEST_HOST_LOOP_N 32
> +#define TEST_HOST_LOOP_N 32UL
> /* Interval for each host loop (ms) */
> -#define TEST_HOST_LOOP_INTERVAL 10
> +#define TEST_HOST_LOOP_INTERVAL 10UL
>
> /*
> * Guest variables. We use these variables to share data between host
>

Thanks for the patch. Applied to linux-kselftest next for 4.20-rc1

thanks,
-- Shuah

\
 
 \ /
  Last update: 2018-10-16 16:50    [W:0.035 / U:4.024 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site