lkml.org 
[lkml]   [2018]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: net/wan: hostess_sv11 + z85230 problems
From
Date
On 10/15/18 1:20 AM, Krzysztof Hałasa wrote:
> Hi,
>
> Randy Dunlap <rdunlap@infradead.org> writes:
>
>> kernel 4.19-rc7, on i386, with NO wan/hdlc/hostess/z85230 hardware:
>>
>> modprobe hostess_sv11 + autoload of z85230 give:
>
> BTW Hostess SV11 is apparently an ISA card, with all those problems.

Yeah.

>> [ 3162.511877] Call Trace:
...
>
> Not sure about z8530 internals (driver and hw), but I guess the sv11
> driver should initialize the hw first, and only then request_irq().
> Perhaps there should be no "default address" either? The user would
> have to provide the hardware parameters explicitly.
>
> How about this (totally untested):
> Fix the Hostess SV11 driver trying to use the hardware before its
> existence is detected.
>
> Signed-off-by: Krzysztof Halasa <khalasa@piap.pl>

Tested-by: Randy Dunlap <rdunlap@infradead.org>

or you can just rm it, like Alan suggested.

thanks.
--
~Randy

\
 
 \ /
  Last update: 2018-10-16 00:24    [W:0.078 / U:6.584 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site