lkml.org 
[lkml]   [2018]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/7] NULL pointer deref fix for stm32-dma
Hi Joel,

On 08-10-18, 22:47, Joel Fernandes (Google) wrote:
> Hi Greg,
>
> While looking at android-4.14, I found a NULL pointer deref with
> stm32-dma driver using Coccicheck errors. I found that upstream had a
> bunch of patches on stm32-dma that have fixed this and other issues, I
> applied these patches cleanly onto Android 4.14. I believe these should
> goto stable and flow into Android 4.14 from there, but I haven't tested
> this since I have no hardware to do so.
>
> Atleast I can say that the coccicheck error below goes away when running:
> make coccicheck MODE=report
> ./drivers/dma/stm32-dma.c:567:18-24: ERROR: chan -> desc is NULL but dereferenced.
>
> Anyway, please consider this series for 4.14 stable, I have CC'd the
> author and others, thanks.
>
> Pierre Yves MORDRET (7):
> dmaengine: stm32-dma: threshold manages with bitfield feature
> dmaengine: stm32-dma: fix incomplete configuration in cyclic mode
> dmaengine: stm32-dma: fix typo and reported checkpatch warnings
> dmaengine: stm32-dma: Improve memory burst management
> dmaengine: stm32-dma: fix DMA IRQ status handling
> dmaengine: stm32-dma: fix max items per transfer
> dmaengine: stm32-dma: properly mask irq bits

It would be good to only cherry pick fixes for this. I do not feel that
some of them which are adding or enhancing driver belong to stable.

Thanks
--
~Vinod

\
 
 \ /
  Last update: 2018-10-15 19:01    [W:0.067 / U:1.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site