Messages in this thread | | | Subject | Re: [PATCH 1/6] mm: get_user_pages: consolidate error handling | From | John Hubbard <> | Date | Fri, 12 Oct 2018 15:45:05 -0700 |
| |
On 10/11/18 11:30 PM, Balbir Singh wrote: > On Thu, Oct 11, 2018 at 11:00:09PM -0700, john.hubbard@gmail.com wrote: >> From: John Hubbard <jhubbard@nvidia.com> >> >> An upcoming patch requires a way to operate on each page that >> any of the get_user_pages_*() variants returns. >> >> In preparation for that, consolidate the error handling for >> __get_user_pages(). This provides a single location (the "out:" label) >> for operating on the collected set of pages that are about to be returned. >> >> As long every use of the "ret" variable is being edited, rename >> "ret" --> "err", so that its name matches its true role. >> This also gets rid of two shadowed variable declarations, as a >> tiny beneficial a side effect. >> >> Reviewed-by: Jan Kara <jack@suse.cz> >> Reviewed-by: Andrew Morton <akpm@linux-foundation.org> >> Signed-off-by: John Hubbard <jhubbard@nvidia.com> >> --- > > Looks good, might not be needed but > Reviewed-by: Balbir Singh <bsingharora@gmail.com> >
Thanks for the review, very good to have another set of eyes on this one.
-- thanks, John Hubbard NVIDIA
| |