lkml.org 
[lkml]   [2018]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] esp_scsi: De-duplicate PIO routines
On Sat, Oct 13, 2018 at 06:22:18PM +1100, Finn Thain wrote:
> > > + pr_err("FIFO is empty (sreg %02x)\n", esp_read8(ESP_STATUS));
> >
> > This should probably use dev_err (at least with my series).
> >
>
> How about shost_printk()? That would be consistent with the rest of
> esp_scsi.c. It also means my series need not depend on yours which would
> complicate things.

Yes, that sounds even better.

\
 
 \ /
  Last update: 2018-10-13 09:52    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog