lkml.org 
[lkml]   [2018]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] x86: ptrace: Add function argument access API
On Fri, 12 Oct 2018 11:21:28 -0700
Andy Lutomirski <luto@amacapital.net> wrote:

> On Fri, Oct 12, 2018 at 9:26 AM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> >
> > Anyone have any issues with this patch?
> >
>
> I'm conceptually okay with it. That being said,
> regs_within_kernel_stack(), which you're indirectly using, is
> off-by-a-few. And updating it to use probe_kernel_read() might be
> nice for robustness.
>

100% agree. I'll add a patch on top of it to make the changes, and keep
what Masami had originally for full history.

Thanks for taking the time to take a look at it.

-- Steve

\
 
 \ /
  Last update: 2018-10-12 20:23    [W:0.143 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site