Messages in this thread | | | From | Dan Williams <> | Date | Fri, 12 Oct 2018 09:58:18 -0700 | Subject | Re: [PATCHv2] mm/gup: Cache dev_pagemap while pinning pages |
| |
On Fri, Oct 12, 2018 at 4:00 AM Kirill A. Shutemov <kirill@shutemov.name> wrote: [..] > > Does this have defined behavior? I would feel better with " = { 0 }" > > to be explicit. > > Well, it's not allowed by the standart, but GCC allows this. > You can see a warning with -pedantic. > > We use empty-list initializers a lot in the kernel: > $ git grep 'struct .*= {};' | wc -l > 997 > > It should be fine.
Ah, ok. I would still say we should be consistent between the init syntax for 'ctx' in follow_page() and __get_user_pages(), and why not go with '= { 0 }', one less unnecessary gcc'ism.
| |