Messages in this thread | | | Subject | Re: [PATCH] KEYS: trusted: fix -Wvarags warning | From | Denis Kenzior <> | Date | Fri, 12 Oct 2018 10:53:43 -0500 |
| |
Hi James,
>> From the links provided in the patch it seems that one cannot pass >> char/float/short to va_start(). Fair enough. So if we make h3 an >> unsigned int, the issue goes away, no? > > For the current version of clang, yes. However, if we're fixing this > for good a char * pointer is the only guaranteed thing because it > mirrors current use in printf. >
All right. I guess I wasn't aware that non-printf like variadic functions are now considered harmful or of the impending crusade against them :)
But in the context of this patch, can we please use something less invasive than changing all the arguments around? Promoting h3 to a bool (if possible) or int/unsigned int would get my vote.
Regards, -Denis
| |