Messages in this thread | | | Subject | Re: usbnet private-data accessor functions | From | Oliver Neukum <> | Date | Fri, 12 Oct 2018 17:38:48 +0200 |
| |
On Fr, 2018-10-12 at 10:16 +0100, Ben Dooks wrote: > I have been looking at the usbnet drivers and the possibility of some > code cleanups. One of the things I've found is that changing the way > the drivers use the private data with the usbnet structure is often > hand-coded each time is needed.
Where is the improvement? You are just hiding how the data is passed. It may look more pleasant to you, but that is a subjective impression. I would suggest that if you want a nicely named way to get at private data, add a field to the appropriate data structure.
Regards Oliver
| |