[lkml]   [2018]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] afs: Fix cell proc list
On Thu, Oct 11, 2018 at 10:45:49PM +0100, David Howells wrote:
> Access to the list of cells by /proc/net/afs/cells has a couple of
> problems:
> (1) It should be checking against SEQ_START_TOKEN for the keying the
> header line.
> (2) It's only holding the RCU read lock, so it can't just walk over the
> list without following the proper RCU methods.
> Fix these by using an hlist instead of an ordinary list and using the
> appropriate accessor functions to follow it with RCU.
> Since the code that adds a cell to the list must also necessarily change,
> sort the list on insertion whilst we're at it.
> Fixes: 989782dcdc91 ("afs: Overhaul cell database management")
> Signed-off-by: David Howells <>

Now applied, thanks.

greg k-h

 \ /
  Last update: 2018-10-12 13:32    [W:0.024 / U:9.032 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site