Messages in this thread | | | Subject | Re: [PATCH v4 3/3] iio: magnetometer: Add driver support for PNI RM3100 | From | Song Qiang <> | Date | Fri, 12 Oct 2018 16:36:01 +0800 |
| |
On 2018年10月12日 15:35, Song Qiang wrote: > PNI RM3100 is a high resolution, large signal immunity magnetometer, > composed of 3 single sensors and a processing chip with a MagI2C > interface. > ... > +static irqreturn_t rm3100_trigger_handler(int irq, void *p) > +{ > + struct iio_poll_func *pf = p; > + struct iio_dev *indio_dev = pf->indio_dev; > + unsigned long scan_mask = *indio_dev->active_scan_mask; > + unsigned int mask_len = indio_dev->masklength; > + struct rm3100_data *data = iio_priv(indio_dev); > + struct regmap *regmap = data->regmap; > + int ret, i, bit; > + > + mutex_lock(&data->lock); > + switch (scan_mask) { > + case BIT(0) | BIT(1) | BIT(2): > + ret = regmap_bulk_read(regmap, RM3100_REG_MX2, data->buffer, 9); > + mutex_unlock(&data->lock); > + if (ret < 0) > + goto done; > + break; > + case BIT(0) | BIT(1): > + ret = regmap_bulk_read(regmap, RM3100_REG_MX2, data->buffer, 6); > + mutex_unlock(&data->lock); > + if (ret < 0) > + goto done; > + break; > + case BIT(1) | BIT(2): > + ret = regmap_bulk_read(regmap, RM3100_REG_MY2, data->buffer, 6); > + mutex_unlock(&data->lock); > + if (ret < 0) > + goto done; > + break; Hi Jonathan,
I just noticed that these three breaks are not proper aligned.
yours, Song Qiang
| |