lkml.org 
[lkml]   [2018]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 028/120] scsi: target/iscsi: Make iscsit_ta_authentication() respect the output buffer size
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Bart Van Assche <bart.vanassche@wdc.com>

    [ Upstream commit 35bea5c84fd13c643cce63f0b5cd4b148f8c901d ]

    Fixes: e48354ce078c ("iscsi-target: Add iSCSI fabric support for target v4.1")
    Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
    Reviewed-by: Mike Christie <mchristi@redhat.com>
    Cc: Mike Christie <mchristi@redhat.com>
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Hannes Reinecke <hare@suse.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/target/iscsi/iscsi_target_tpg.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/target/iscsi/iscsi_target_tpg.c
    +++ b/drivers/target/iscsi/iscsi_target_tpg.c
    @@ -651,8 +651,7 @@ int iscsit_ta_authentication(struct iscs
    none = strstr(buf1, NONE);
    if (none)
    goto out;
    - strncat(buf1, ",", strlen(","));
    - strncat(buf1, NONE, strlen(NONE));
    + strlcat(buf1, "," NONE, sizeof(buf1));
    if (iscsi_update_param_value(param, buf1) < 0)
    return -EINVAL;
    }

    \
     
     \ /
      Last update: 2018-10-11 18:02    [W:4.110 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site