lkml.org 
[lkml]   [2018]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] mm/sparse: add common helper to mark all memblocks present
> +	for_each_memblock(memory, reg) {
> + int nid = memblock_get_region_node(reg);
> +
> + memory_present(nid, memblock_region_memory_base_pfn(reg),
> + memblock_region_memory_end_pfn(reg));

Any reason you have a local variable for the node id while you happily
get away without one for the others? Why not simply:

for_each_memblock(memory, reg) {
memory_present(memblock_get_region_node(reg)
memblock_region_memory_base_pfn(reg),
memblock_region_memory_end_pfn(reg));
}

\
 
 \ /
  Last update: 2018-10-11 15:31    [W:0.120 / U:0.868 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site