lkml.org 
[lkml]   [2018]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] dw: spi: add support for Alpine spi controller
Date
On Wed, 2018-10-10 at 18:15 +0300, Talel Shenhar wrote:
> Add support for a new devicetree compatible string called
> 'al,alpine-apb-ssi', which is necessary for the Amazon Alpine spi
> controller. 'al,alpine-dw-apb-ssi' is used in the dw spi driver if
> specified in the devicetree. Otherwise, fall back to driver default
> behavior, i.e. original dw IP hw driver behavior.
>
> Signed-off-by: Talel Shenhar <talel@amazon.com>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>

Shouldn't this be "amzn,alpine-apb-ssi"? The convention, and this IS
documented, is to the use company's stock ticker symbol as the prefix,
so as to have something grounded in the real world. I don't know of
anyone else using a product line name as the company name in their dt
bindings. Example, "snps,dw-apb-ssi", is named for Synopsis, not the
Designware line.

\
 
 \ /
  Last update: 2018-10-11 00:10    [W:0.064 / U:1.980 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site