lkml.org 
[lkml]   [2018]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: vboxvideo: make a couple of funcs static
From
Date
Hi,

On 10-10-18 22:17, Craig Kewley wrote:
> Fix Sparse warnings:
> drivers/staging/vboxvideo/vbox_mode.c:309:6: warning:
> symbol 'vbox_primary_atomic_disable' was not declared. Should it be static?
>
> drivers/staging/vboxvideo/vbox_mode.c:452:6: warning:
> symbol 'vbox_cursor_atomic_disable' was not declared. Should it be static?
>
> Signed-off-by: Craig Kewley <craigkewley@gmail.com>

Thanks.

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
> drivers/staging/vboxvideo/vbox_mode.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
> index 042e4f384df9..deed28c7a1db 100644
> --- a/drivers/staging/vboxvideo/vbox_mode.c
> +++ b/drivers/staging/vboxvideo/vbox_mode.c
> @@ -306,8 +306,8 @@ static void vbox_primary_atomic_update(struct drm_plane *plane,
> plane->state->src_y >> 16);
> }
>
> -void vbox_primary_atomic_disable(struct drm_plane *plane,
> - struct drm_plane_state *old_state)
> +static void vbox_primary_atomic_disable(struct drm_plane *plane,
> + struct drm_plane_state *old_state)
> {
> struct drm_crtc *crtc = old_state->crtc;
>
> @@ -449,8 +449,8 @@ static void vbox_cursor_atomic_update(struct drm_plane *plane,
> mutex_unlock(&vbox->hw_mutex);
> }
>
> -void vbox_cursor_atomic_disable(struct drm_plane *plane,
> - struct drm_plane_state *old_state)
> +static void vbox_cursor_atomic_disable(struct drm_plane *plane,
> + struct drm_plane_state *old_state)
> {
> struct vbox_private *vbox =
> container_of(plane->dev, struct vbox_private, ddev);
>

\
 
 \ /
  Last update: 2018-10-11 10:55    [W:0.049 / U:11.144 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site