lkml.org 
[lkml]   [2018]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v12 2/3]: perf record: enable asynchronous trace writing
From
Date
On 11.10.2018 16:45, Jiri Olsa wrote:
> On Tue, Oct 09, 2018 at 11:58:53AM +0300, Alexey Budankov wrote:
>
> SNIP
>
>> @@ -1378,6 +1566,22 @@ static int parse_clockid(const struct option *opt, const char *str, int unset)
>> return -1;
>> }
>>
>> +#ifdef HAVE_AIO_SUPPORT
>> +static int record__aio_parse(const struct option *opt,
>> + const char *str __maybe_unused,
>> + int unset)
>> +{
>> + struct record_opts *opts = (struct record_opts *)opt->value;
>> +
>> + if (unset)
>> + opts->nr_cblocks = 0;
>> + else
>> + opts->nr_cblocks = 1;
>> +
>> + return 0;
>> +}
>> +#endif
>
> same, please move this up to have just one 'ifdef HAVE_AIO_SUPPORT' block

Accepted.

>
> thanks,
> jirka
>

\
 
 \ /
  Last update: 2018-10-11 18:16    [W:0.110 / U:0.988 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site