Messages in this thread | | | Subject | Re: [PATCH v12 3/3]: perf record: extend trace writing to multi AIO | From | Alexey Budankov <> | Date | Thu, 11 Oct 2018 19:14:03 +0300 |
| |
Hi, On 11.10.2018 16:45, Jiri Olsa wrote: > On Tue, Oct 09, 2018 at 11:59:31AM +0300, Alexey Budankov wrote: <SNIP> > >> @@ -1886,8 +1917,8 @@ static struct option __record_options[] = { >> OPT_BOOLEAN(0, "dry-run", &dry_run, >> "Parse options then exit"), >> #ifdef HAVE_AIO_SUPPORT >> - OPT_CALLBACK_NOOPT(0, "aio", &record.opts, >> - NULL, "Enable asynchronous trace writing mode", > > hum, why removing --aio option? I though we will have: > > perf record --aio .... # enables aio with default settings > perf record --aio-cblocks=3 ... # enabled aio with aio-cblocks=3
It is possible to avoid the complication using only one --aio option like this:
perf record --aio ... # enables aio with default (=1) perf record --aio=4 ... # enables aio with parameter = 4
--aio-cblocks=4 still works when specified like --aio=4.
Thanks, Alexey
| |