Messages in this thread | | | Subject | Re: [PATCH v2 0/2] tty: erase buffers when the kernel is done with it. | From | Milan Broz <> | Date | Wed, 10 Oct 2018 20:20:06 +0200 |
| |
On 04/10/2018 20:06, Greg Kroah-Hartman wrote: > azlig and Milan Broz reported that when the tty layer is done with a > buffer, the data can hang around in it for a very long time. That > sometimes can "leak" to userspace under some conditions. > > Because of this, just zero out the data after the tty layer is finished > with it, for buffers that we "think" should be zeroed out. > > v2 - addressed some review comments on the 2/2 patch.
Hello Greg,
together with our intern we re-tested both patches and it fixes the reported problem, so, if it helps anything, you can add
Tested-by: Milan Broz <gmazyland@gmail.com> Tested-by: Daniel Zatovic <daniel.zatovic@gmail.com>
Do you plan to add this to linux-next?
Thanks! Milan
> > Greg Kroah-Hartman (1): > tty: wipe buffer if not echoing data > > Linus Torvalds (1): > tty: wipe buffer. > > drivers/tty/n_tty.c | 20 +++++++++++++++++--- > drivers/tty/tty_buffer.c | 6 +++++- > 2 files changed, 22 insertions(+), 4 deletions(-) >
| |